Make StatusBarManager use main queue setup#50113
Closed
RSNara wants to merge 7 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
a1fdba7 to
0b3f60a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
0b3f60a to
22534ea
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
22534ea to
8e9b5f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
8e9b5f6 to
bfea6c2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
bfea6c2 to
7a1a091
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
7a1a091 to
ec8b840
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
ec8b840 to
af93938
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
af93938 to
c67603a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
c67603a to
8e91de0
Compare
Summary: Pull Request resolved: facebook#50111 ## Rationale Rendering can now include main -> js sync calls. If we allow js -> main sync calls during rendering, react native can deadlock. So, this diff moves the js -> main sync calls to "main queue module setup", which occurs before rendering. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D71480047
Summary: Pull Request resolved: facebook#50109 ## Rationale Rendering can now include main -> js sync calls. If we allow js -> main sync calls during rendering, react native can deadlock. So, this diff moves the js -> main sync calls to "main queue module setup", which occurs before rendering. Changelog: [Internal] Differential Revision: D71347449 Reviewed By: mdvacca
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
8e91de0 to
83d2dee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
83d2dee to
88e2b41
Compare
Summary: Pull Request resolved: facebook#50112 ## Rationale Rendering can now include main -> js sync calls. If we allow js -> main sync calls during rendering, react native can deadlock. So, this diff moves the js -> main sync calls to "main queue module setup", which occurs before rendering. Changelog: [Internal] Differential Revision: D71347448 Reviewed By: mdvacca
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
88e2b41 to
bca011e
Compare
Summary: Pull Request resolved: facebook#50113 ## Rationale Rendering can now include main -> js sync calls. If we allow js -> main sync calls during rendering, react native can deadlock. So, this diff moves the js -> main sync calls to "main queue module setup", which occurs before rendering. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D71348559
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71348559 |
RSNara
force-pushed
the
export-D71348559
branch
from
bca011e to
aec510b
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Mar 19, 2025
Summary: Pull Request resolved: facebook#50113 ## Rationale Rendering can now include main -> js sync calls. If we allow js -> main sync calls during rendering, react native can deadlock. So, this diff moves the js -> main sync calls to "main queue module setup", which occurs before rendering. Changelog: [Internal] Differential Revision: D71348559 Reviewed By: mdvacca
Contributor
|
This pull request has been merged in b4775eb. |
|
@RSNara thank you for this PR, how to use it with the experimental flag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rationale
Rendering can now include main -> js sync calls.
If we allow js -> main sync calls during rendering, react native can deadlock.
So, this diff moves the js -> main sync calls to "main queue module setup", which occurs before rendering.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D71348559